Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scale parameter to HeatTransferFromHeatStructure1Phase #28669

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

joshuahansel
Copy link
Contributor

This adds a parameter scale to HeatTransferFromHeatStructure1Phase, which can be used to enhance heat transfer due to fins.

Refs #25275

Copy link
Contributor

@licharlot licharlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should you also add a test for the HSBoundaryAmbientConvection component?

@moosebuild
Copy link
Contributor

moosebuild commented Sep 19, 2024

Job Documentation on 08bd243 wanted to post the following:

View the site here

This comment will be updated on new commits.

@joshuahansel
Copy link
Contributor Author

Should you also add a test for the HSBoundaryAmbientConvection component?

There already is one.

@moosebuild
Copy link
Contributor

Job Coverage on 08bd243 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Thermal hydraulics

a1cbad #28669 08bd24
Total Total +/- New
Rate 88.45% 88.46% +0.00% 100.00%
Hits 13691 13697 +6 8
Misses 1787 1787 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants